feat: add support for the mill wrapper #534
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignoring the CI failures since they are unrelated and will be fixed by #546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mill wrapper based on the work to support wrapper for gradle.
Ref: #533
Test plan
I published scip-java locally -
sbt scip-java/publishLocal,and then I invoked indexing in my project via coursier -
cs launch com.sourcegraph:scip-java_2.13:0.8.13-1-e2b668bb-SNAPSHOT -- index --build-tool=millIndexing completed successfully:
In general it can be tested by running
scip-java indexin a scala project that uses mill together with mill wrapper.I did not write any automated tests as I didn't find anything like that for gradle wrapper. Let me know if I should add some automated tests.