refactor(build): remove explicit dependency on Bloop #483
+8
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit opinionated, so no worries if you'd rather not, but when working on sourcegraph#477 I had a pretty hard time with Bloop, but when using sbt things seems to go much smoother. This pr does a couple things: - Updates the contributing docs from "don't use <insert-editor>" -> Feel free to use Metals with lesser support than IntelliJ will give you. It also then recommends using sbt as your build server. - Remove the explicit dependency on `sbt-bloop`. This both gets rid of some complexity in the build by removing the Bloop-explicit stuff which I assume most non-Scala devs aren't familiar with. - Removes the `BuildInfo.bloopVersion` which didn't seem to be used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit opinionated, so no worries if you'd rather not, but when
working on #477 I had a pretty hard time with Bloop, but when using sbt
things seems to go much smoother. This pr does a couple things:
Feel free to use Metals with lesser support than IntelliJ will give
you. It also then recommends using sbt as your build server.
sbt-bloop. This both gets rid ofsome complexity in the build by removing the Bloop-explicit stuff
which I assume most non-Scala devs aren't familiar with.
BuildInfo.bloopVersionwhich didn't seem to be usedanywhere.
Test plan
All tests should remain 🟢 .