Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] update python package docker in host image to 6.1.1 #14993

Merged
merged 1 commit into from
May 10, 2023
Merged

[Build] update python package docker in host image to 6.1.1 #14993

merged 1 commit into from
May 10, 2023

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented May 9, 2023

@k-v1 k-v1 requested a review from lguohan as a code owner May 9, 2023 19:51
@k-v1
Copy link
Contributor Author

k-v1 commented May 9, 2023

@xumia
Probably you can also review this.
New version of python package docker is enough to fix build failure.
Another solution is to pin urllib3<2 and requests<2.29, but I think better solution is to use new version of docker package.

@xumia xumia requested a review from liushilongbuaa May 9, 2023 22:33
@xumia
Copy link
Collaborator

xumia commented May 9, 2023

LGTM, @liushilongbuaa , could you please help review it? Thanks.

liushilongbuaa
liushilongbuaa approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@liushilongbuaa liushilongbuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. both 6.1.0 and 6.1.1 are good.

@lguohan lguohan merged commit bba4fb8 into sonic-net:master May 10, 2023
19 checks passed
@aparkhomenko-xsight
Copy link

@lguohan could you also cherry-pick it to 202211 branch?
Seems like issue was with 202211 branch

@mlok-nokia
Copy link
Contributor

mlok-nokia commented May 11, 2023 •
edited

@judyjoseph @lguohan @liushilongbuaa This issue also shows up on 202205 branch. Could you please cherry-pick to the 202205 branch?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 12, 2023
@k-v1 @mssonicbld
[Build] update python package docker in host image to 6.1.1 (sonic-ne…
20eb91e 
…t#14993)

Fix sonic-net#14974
Refs: docker/docker-py#3116
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202106: #15044

@mssonicbld mssonicbld mentioned this pull request May 12, 2023
Merged
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 12, 2023
@k-v1 @mssonicbld
[Build] update python package docker in host image to 6.1.1 (sonic-ne…
36b66ac 
…t#14993)

Fix sonic-net#14974
Refs: docker/docker-py#3116
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202111: #15045

@mssonicbld mssonicbld mentioned this pull request May 12, 2023
Merged
mssonicbld added a commit that referenced this pull request May 12, 2023
@mssonicbld
[Build] update python package docker in host image to 6.1.1 (#14993) (#…
451944c 
…15044)
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 12, 2023
@k-v1 @mssonicbld
[Build] update python package docker in host image to 6.1.1 (sonic-ne…
6b09e86 
…t#14993)

Fix sonic-net#14974
Refs: docker/docker-py#3116
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15050

@mssonicbld mssonicbld mentioned this pull request May 12, 2023
Merged
yxieca pushed a commit that referenced this pull request May 15, 2023
@mssonicbld @k-v1
[Build] update python package docker in host image to 6.1.1 (#14993) (#…
4ee8224 
…15050)

Fix #14974
Refs: docker/docker-py#3116

Co-authored-by: Konstantin Vasin <126960927+k-v1@users.noreply.github.com>
mssonicbld pushed a commit that referenced this pull request May 19, 2023
@k-v1 @mssonicbld
[Build] update python package docker in host image to 6.1.1 (#14993)
7a87170 
Fix #14974
Refs: docker/docker-py#3116
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 28, 2023
@k-v1 @mssonicbld
[Build] update python package docker in host image to 6.1.1 (sonic-ne…
9c49de6 
…t#14993)

Fix sonic-net#14974
Refs: docker/docker-py#3116
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15989

@mssonicbld mssonicbld mentioned this pull request Jul 28, 2023
Merged
mssonicbld added a commit that referenced this pull request Jul 28, 2023
@mssonicbld
[Build] update python package docker in host image to 6.1.1 (#14993) (#…
0bcbd81 
…15989)
@ec-michael-shih ec-michael-shih mentioned this pull request Dec 5, 2023
Merged
7 tasks
ec-michael-shih added a commit to ec-michael-shih/ec-sonic-buildimage that referenced this pull request Dec 12, 2023
@ec-michael-shih
[AS4630-54NPE] Apply community PR
79faed1 
Apply community PR :

sonic-net/sonic-buildimage#14293

Detail:
  sonic-net/sonic-buildimage#14292

  as4630-54npe already merge(at commit id: 4be14f0) the PRs below:
  sonic-net/sonic-buildimage#13241
  sonic-net/sonic-buildimage#13288
  sonic-net/sonic-buildimage#15002
  sonic-net/sonic-buildimage#13685
  sonic-net/sonic-buildimage#14475
  sonic-net/sonic-buildimage#14993
  sonic-net/sonic-buildimage#14919
  sonic-net/sonic-buildimage#15461
  sonic-net/sonic-buildimage#16114
  sonic-net/sonic-buildimage#334
@ec-michael-shih ec-michael-shih mentioned this pull request Dec 12, 2023
Merged
@ec-michael-shih ec-michael-shih mentioned this pull request Jan 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liushilongbuaa liushilongbuaa liushilongbuaa approved these changes

@xumia xumia xumia approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Included in 202106 Branch Included in 202111 Branch Included in 202205 Branch Included in 202211 Branch Request for 202205 Branch Request for 202211 Branch
Projects
None yet
Milestone
No milestone
8 participants
@k-v1 @xumia @aparkhomenko-xsight @mlok-nokia @mssonicbld @liushilongbuaa @lguohan @yxieca