Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update socket.ts: Change the socket.data type from Partial<SocketData… #4740

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Update socket.ts: Change the socket.data type from Partial<SocketData… #4740

merged 2 commits into from
Jun 20, 2023

Commits on Jun 18, 2023

  1. Update socket.ts: Change the socket.data type from Partial<SocketData… 

    …> to SocketData

Wrapping SocketData with Partial causes issues when reading data even if you've made sure to pass all values. If someone want to make their type Partial or make only a few properties optional, they can do so in their own type instead.
    @SyedTayyabUlMazhar
    SyedTayyabUlMazhar committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    583196e View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. fix ts issue

    @darrachequesne
    darrachequesne committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    83d7973 View commit details
    Browse the repository at this point in the history