fix NodeNext module resolution compatibility #4625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
misbahkhalilaz
approved these changes
Feb 16, 2023
darrachequesne
pushed a commit
that referenced
this pull request
Feb 20, 2023
|
Merged as d0b22c6. Thanks! |
haneenmahd
pushed a commit
to haneenmahd/socket.io
that referenced
this pull request
Apr 15, 2023
The import added in [1] was invalid, because it used an non-exported class. Related: socketio#4621 [1]: socketio@d4a9b2c
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
The import added in [1] was invalid, because it used an non-exported class. Related: socketio#4621 [1]: socketio@6652a3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Types are not found when typescript moduleResolution is set to NodeNext, issue #4621
New behavior
Works normally with NodeNext
Other information (e.g. related issues)
Must be merged together with the engine.io PR socketio/engine.io#669