Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(openai): add all openai models to Model enum #136

Merged
merged 2 commits into from
May 22, 2023

Conversation

joshka
Copy link
Contributor

@joshka joshka commented May 22, 2023

Use https://crates.io/crates/strum for the FromStr implementation, and include a few useful overrides that make it easy to specify a model from a user provided string.

Note: strum contains a ToString implementation too, but it doesn't currently handle writing the contents of a default Tuple-like enum (Model::Other(String)), but there is a PR for fixing that at:

Use https://crates.io/crates/strum for the FromStr implementation, and
include a few useful overrides that make it easy to specify a model from
a user provided string.
@joshka
Copy link
Contributor Author

joshka commented May 22, 2023

image

@williamhogman williamhogman merged commit 0aaec97 into sobelio:main May 22, 2023
5 checks passed
@joshka joshka deleted the openai-models branch May 23, 2023 06:48
@joshka
Copy link
Contributor Author

joshka commented May 23, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants