Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for blank OR null on asset tag/serial formatter #16047

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 9, 2025

This checks for a blank value or a null value before adding the strikethrough indicating an asset was deleted. The previous behavior would show a strikethrough even if the deleted_at was null.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jan 9, 2025

PR Summary

  • Simplified condition for asset deletion check
    We've improved the way we check if an asset has been deleted to make it more efficient. Instead of comparing the asset's delete time to an empty string, we now just check if the delete time exists. This change makes the code easier to read and understand.

@snipe snipe merged commit c284ac5 into develop Jan 9, 2025
9 checks passed
@snipe snipe deleted the bug/sc-28054 branch January 9, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant