Prefer ID for hasTrait lookups #2562
Merged
+558
−441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
approved these changes
Mar 11, 2025
| @@ -129,7 +129,7 @@ private List<ValidationEvent> validateOperation( | |||
| isReadonly ? UNNECESSARY_READONLY_TRAIT : MISSING_READONLY_TRAIT)); | |||
| } | |||
|
|
|||
| boolean isIdempotent = shape.getTrait(IdempotentTrait.class).isPresent(); | |||
| boolean isIdempotent = shape.hasTrait(IdempotentTrait.class); | |||
There was a problem hiding this comment.
Suggested change
| boolean isIdempotent = shape.hasTrait(IdempotentTrait.class); | |
| boolean isIdempotent = shape.hasTrait(IdempotentTrait.ID); |
kstich
force-pushed
the
trait_lookup_opt
branch
from
b2952ba to
d6a31be
Compare
sugmanue
approved these changes
Mar 11, 2025
This commit updates all calls to `hasTrait` from using Class based lookups to use ID based lookups. Traits are stored on a Shape in a ShapeId-keyed map. Using this will be faster than testing values via `isInstance`. The lookup for `hasTrait(ShapeId)` is also updated to do a simple `containsKey` check on the map. This eliminates using `findTrait` which creates an intermediate `Optional` only to throw it away.
kstich
force-pushed
the
trait_lookup_opt
branch
from
d6a31be to
0dd9a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates all calls to
hasTraitfrom using Class based lookups to use ID based lookups. Traits are stored on aShapein aShapeId-keyed map. Using this will be faster than testing values viaisInstance.The lookup for
hasTrait(ShapeId)is also updated to do a simplecontainsKeycheck on the map. This eliminates usingfindTraitwhich creates an intermediateOptionalonly to throw it away.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.