Allow AggregatedBytes to be constructed directly from segmented bytes #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for cases where a segmented buffer of bytes is already present. A good used case is for streaming the segmented bytes to S3 as a single object.
|
Thank you for contributing! I suspect our CI may not be happy with the change because it now exposes in a stable crate (
Since you mentioned "Internal to this crate", maybe you mean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is useful for cases where I already have a segmented buffer of bytes, and I need to stream them to S3 as a single object.
Description
Internal to this crate, the AggregatedBytes struct can be constructed directly from a SegmentedBytes buffer.
There are cases where folks would like to perform this same thing.
Testing
I am currently using this for a project where a segmented buffer of bytes is streamed to S3 as a single object.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.