re-enable content length enforcement #3618
Merged
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Blocked by #3620 landing and a new version of the SDK released with that test ignored so that semver hazards check can pass. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
## Motivation and Context #3618 is blocked by semver hazards check because the current version of this test in `aws-sdk-rust` expects the test to [panic](https://github.com/smithy-lang/smithy-rs/blob/release-2024-04-30/aws/sdk/integration-tests/s3/tests/streaming-response.rs#L23). To land the content length enforcement PR we need to ignore the test and release `smithy-rs` and a version of the SDK with the test ignored instead of expecting it to panic. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
ogghead
pushed a commit
to ogghead/smithy-rs
that referenced
this pull request
May 5, 2024
## Motivation and Context smithy-lang#3618 is blocked by semver hazards check because the current version of this test in `aws-sdk-rust` expects the test to [panic](https://github.com/smithy-lang/smithy-rs/blob/release-2024-04-30/aws/sdk/integration-tests/s3/tests/streaming-response.rs#L23). To land the content length enforcement PR we need to ignore the test and release `smithy-rs` and a version of the SDK with the test ignored instead of expecting it to panic. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
aajtodd
force-pushed
the
atodd/enable-content-length-enforcement
branch
from
cd46750
to
16cdfe1
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR re-enables content-length runtime plugin that was previously disabled due to some erroneous tests. Those tests appear to be fixed.
Original PR: #3491
Tracking issue: #3523
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.