Add method to config that uses an empty test environment #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Apr 4, 2024
| /// This allows for testing in a reproducible environment that ensures any | ||
| /// environment variables from the host do not influence environment variable | ||
| /// resolution. | ||
| pub fn empty_test_environment(mut self) -> Self { |
There was a problem hiding this comment.
I assume we're not gating this behind test-utils or anything (aws-config already has quite a few features to the point that it's not friendly to cargo hack --feature-powerset)
jdisanti
reviewed
Apr 4, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "aws-config" | |||
| version = "1.1.10" | |||
| version = "1.1.11" | |||
There was a problem hiding this comment.
Should be a minor bump, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve testability
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.