Provide a reason for not acceptable server request rejections #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so that when an incoming request's `Accept` header value set cannot be satisfied by the server, the unsatisfiable value set is stored in the `RequestRejection`. The rejection reason will thus be `DEBUG`-logged.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
approved these changes
Apr 20, 2023
| } | ||
| // Must be of the form: type/subtype | ||
| // Must be of the form: `type/subtype`. | ||
| let content_type = content_type |
There was a problem hiding this comment.
Side note: I feel like this conversion can be done in a static once_cell::Lazy outside of this function, then we pass the &Mime into this function instead. That way we're not doing it over and over.
There was a problem hiding this comment.
I looked at Mime::parse and it appears to be a non-negligible process, so putting Mime behind a OnceCell and incurring an atomic read should indeed speed things up.
I also learnt that mime is not actively maintained, and stumbled upon mediatype, which is const-constructible, so for our static mime type coming from the sSDK I think it would make more sense to switch to that. It's also zero-copy, so parsing the request's Accept and Content-Type headers' mime types and performing the type + subtype equality check should be faster.
There was a problem hiding this comment.
For the first part: #2629
82marbag
reviewed
Apr 24, 2023
| // This is used across different protocol-specific `rejection` modules. | ||
| #[derive(Debug, Error)] | ||
| pub enum NotAcceptableReason { | ||
| #[error("cannot satisfy any of `Accept` header values: {0:?}")] |
2 tasks
82marbag
added a commit
that referenced
this pull request
Apr 26, 2023
## Description Do not parse and initialize the mime, known at compile time, on every request. See #2607 (comment) ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez
pushed a commit
that referenced
this pull request
May 18, 2023
## Description Do not parse and initialize the mime, known at compile time, on every request. See #2607 (comment) ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Description Do not parse and initialize the mime, known at compile time, on every request. See #2607 (comment) ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Description Do not parse and initialize the mime, known at compile time, on every request. See #2607 (comment) ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that when an incoming request's
Acceptheadervalue set cannot be satisfied by the server, the unsatisfiable value set
is stored in the
RequestRejection. The rejection reason will thus beDEBUG-logged.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.