Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.66.1 #2468

Merged
merged 16 commits into from Mar 16, 2023
Merged

Update MSRV to 1.66.1 #2468

merged 16 commits into from Mar 16, 2023

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Mar 15, 2023

Motivation and Context

#2467

Description

Updates the MSRV to 1.66.1

Testing

ran existing tests

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested review from a team as code owners March 15, 2023 19:16
@Velfi Velfi requested review from crisidev and hlbarber March 15, 2023 19:16
@github-actions
Copy link

@Velfi Velfi requested a review from a team as a code owner March 15, 2023 21:33
@Velfi Velfi requested a review from unexge March 15, 2023 21:33
@github-actions
Copy link

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change the default list of clippy lints in kotlin

Self::Md5 => Box::new(Md5::default()),
Self::Sha1 => Box::new(Sha1::default()),
Self::Sha256 => Box::new(Sha256::default()),
Self::Crc32 => Box::<Crc32>::default(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thanks clippy but that is definitely not better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm getting a bit annoyed at Clippy. The last few MSRV updates have introduced some really pedantic lints.

update: codegen clippy lint allowlist
@github-actions
Copy link

@github-actions
Copy link

@Velfi
Copy link
Contributor Author

Velfi commented Mar 16, 2023

I had to fix several tests that were failing due to creating a module named "lib". Those changes need the most review. Affected modules are the structure and enum generator tests and a recursive struct test.

@Velfi
Copy link
Contributor Author

Velfi commented Mar 16, 2023

If you approve this PR, then please merge it

@github-actions
Copy link

@@ -109,13 +113,16 @@ impl SdkBody {
}
}

/// When an SdkBody is read, the inner data must be consumed. In order to do this, the SdkBody
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding docs!

@jdisanti jdisanti added this pull request to the merge queue Mar 16, 2023
Merged via the queue into main with commit 92952cb Mar 16, 2023
36 of 37 checks passed
@jdisanti jdisanti deleted the msrv/1.66.1 branch March 16, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants