You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is just the first part, there are lot of file changes, but changes are repetitive. In particular each EA folder has 3 changes
new entries are added into test-payload.json. These new entries are mostly the same payloads but with endpoint names and aliases. This makes sure that for every endpoint+aliases we have configuration for soak testing.
new unit test is added (either in existing file or in a new file) that ensures that test-payload.json always contains requests with all endpoints+aliases. If new endpoint is added/updated and test-paylaod is not updated, unit test will fail
tsconfig.test.json is updated to include test-payload.json so that the test file can import test-payload.json
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The code itself looks great, it's clear you were careful with the set of endpoints and payloads for each adapter. Would you be able to resolve the conflicts, then let the soak test re-run and I can ✅ after that?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karen-stepanyan
force-pushed
the
feature/DF-18523
branch
from
Part 1 of DF-18523
Although this is just the first part, there are lot of file changes, but changes are repetitive. In particular each EA folder has 3 changes
test-payload.json. These new entries are mostly the same payloads but with endpoint names and aliases. This makes sure that for every endpoint+aliases we have configuration for soak testing.