New NovaPoshta Adapter 1.0.0 #2294

alexbakers · 2022-11-04T00:08:28Z

Description

NovaPoshta Adapter for tracking parcels.

Steps to Test

$ yarn test packages/sources/novaposhta/test/unit/tracking.test.ts 
 PASS  packages/sources/novaposhta/test/unit/tracking.test.ts

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.672 s

$ yarn test packages/sources/novaposhta/test/integration/tracking.test.ts 
 PASS  packages/sources/novaposhta/test/integration/tracking.test.ts
{"level":"warn","time":1667520302342,"pid":88822,"hostname":"Alex-Baker","msg":"Could not load payload: [{\"instancePath\":\"\",\"schemaPath\":\"#/type\",\"keyword\":\"type\",\"params\":{\"type\":\"object\"},\"message\":\"must be object\"}]"}
{"level":"warn","time":1667520302342,"pid":88822,"hostname":"Alex-Baker","msg":"Falling back to default empty payload"}
{"level":"info","time":1667520302351,"pid":88822,"hostname":"Alex-Baker","msg":"Server listening on http://0.0.0.0:51933!"}

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        2.355 s, estimated 3 s

Quality Assurance

If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant <ADAPTER_PACKAGE>/schemas/env.json and <ADAPTER_PACKAGE>/README.md
If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Clubhouse/Shortcut
This is related to a maximum of one Clubhouse/Shortcut story or GitHub issue
Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)
All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

changeset-bot · 2022-11-04T00:08:31Z

⚠️ No Changeset found

Latest commit: ef8ec26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

boxhock

Thanks for opening this PR! Referring to #2293 for the changeset issues

boxhock · 2022-11-07T13:58:37Z

packages/core/legos/package.json

-    "@chainlink/reduce-adapter": "workspace:*",
    "@chainlink/renvm-address-set-adapter": "workspace:*",
-    "@chainlink/rocket-pool-adapter": "workspace:*",


These are being erroneously removed. Let's add them back.

boxhock · 2022-11-07T13:58:48Z

packages/core/legos/tsconfig.json

-    {
-      "path": "../../non-deployable/reduce"
-    },


boxhock · 2022-11-07T13:59:29Z

packages/sources/novaposhta/package.json

@@ -0,0 +1,43 @@
+{
+  "name": "@chainlink/novaposhta-adapter",
+  "version": "1.0.0",


Feel free to start it on 0.0.0, and make a changeset with a "major" version bump, which will make this 1.0.0 when released.

boxhock · 2022-11-07T13:59:46Z

packages/sources/novaposhta/schemas/env.json

@@ -0,0 +1,13 @@
+{
+  "$id": "https://external-adapters.chainlinklabs.com/schemas/example-source-adapter.json",


Suggested change

"$id": "https://external-adapters.chainlinklabs.com/schemas/example-source-adapter.json",

"$id": "https://external-adapters.chainlinklabs.com/schemas/novaposhta-adapter.json",

boxhock · 2022-11-07T14:00:11Z

packages/sources/novaposhta/src/adapter.ts

+  APIEndpoint,
+} from '@chainlink/ea-bootstrap'
+import { makeConfig } from './config'
+import * as endpoints from './endpoint' // The endpoints must be exported as shown in endpoint/index.ts for README generation.


Suggested change

import * as endpoints from './endpoint' // The endpoints must be exported as shown in endpoint/index.ts for README generation.

import * as endpoints from './endpoint'

boxhock · 2022-11-07T14:04:13Z

packages/sources/novaposhta/test-payload.json

+        "number": "59000869676636"
+    }]
+}
+


Suggested change

boxhock · 2022-11-07T14:04:27Z

packages/sources/novaposhta/test/e2e/README.md

@@ -0,0 +1 @@
+Tests that run the adapter and send an end to end request using live API endpoints.


You can remove this file

boxhock · 2022-11-07T14:04:33Z

packages/sources/novaposhta/test/integration/README.md

+Tests that run the adapter and send an end to end request using mocked API endpoints.
+
+See `packages/source/curve/test/integration` and `packages/composite/synth-index/test/integration` for reference. The integration tests are used for the example input/outputs during README generation.


Remove this file

boxhock · 2022-11-07T14:04:47Z

packages/tsconfig.test.json

-    {
-      "path": "./scripts/src/generate-readme/test/integration/readme-test-adapter/tsconfig.test.json"
-    },


Add this back in

boxhock · 2022-11-07T14:05:37Z

packages/sources/novaposhta/src/endpoint/tracking.ts

+const customError = (data: ResponseSchema) => data.success === false
+
+export const description =
+  'Get shipment status by tracking number (https://developers.novaposhta.ua).'


Could you maybe add a link to where the different tracking status codes are explained?

alexbakers

@boxhock thank you very much, you showed in great detail what needs to be fixed.
I will take all the changes.
Please, if I merge branches incorrectly, let me know.

NovaPoshta Chainlink Adapter 1.0.0

e9f3f76

alexbakers mentioned this pull request Nov 4, 2022

Give more information about yarn changeset #2293

Open

boxhock self-requested a review November 7, 2022 12:15

boxhock suggested changes Nov 7, 2022

View reviewed changes

alexbakers and others added 2 commits November 22, 2022 02:40

fix: all recomendations

41da91c

Merge branch 'develop' into develop

ef8ec26

alexbakers commented Nov 22, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New NovaPoshta Adapter 1.0.0 #2294

New NovaPoshta Adapter 1.0.0 #2294

alexbakers commented Nov 4, 2022

changeset-bot bot commented Nov 4, 2022 •

edited

boxhock left a comment

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

boxhock Nov 7, 2022

alexbakers left a comment

		@@ -0,0 +1,13 @@
		{
		"$id": "https://external-adapters.chainlinklabs.com/schemas/example-source-adapter.json",

	import * as endpoints from './endpoint' // The endpoints must be exported as shown in endpoint/index.ts for README generation.
	import * as endpoints from './endpoint'

		@@ -0,0 +1 @@
		Tests that run the adapter and send an end to end request using live API endpoints.

		Tests that run the adapter and send an end to end request using mocked API endpoints.

		See `packages/source/curve/test/integration` and `packages/composite/synth-index/test/integration` for reference. The integration tests are used for the example input/outputs during README generation.

New NovaPoshta Adapter 1.0.0 #2294

Are you sure you want to change the base?

New NovaPoshta Adapter 1.0.0 #2294

Conversation

alexbakers commented Nov 4, 2022

Description

Steps to Test

Quality Assurance

changeset-bot bot commented Nov 4, 2022 • edited

⚠️ No Changeset found

boxhock left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexbakers left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Nov 4, 2022 •

edited