Patch ethereum-cryptography-1.1.2 to work with ncc

[krebernisak]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0c23bd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[krebernisak]

@HenryNguyen5 we could use your help with this issue. cc @cds95

Any idea on the purpose of binding the require fn, module.require.bind(module)?

• ncc builds are failing with Error: Cannot find module 'crypto' at this line.
• This PR is the temporary fix to avoid this issue.

ncc transforms the code to this:

exports.crypto = (() => {
    const webCrypto = typeof self === "object" && "crypto" in self ? self.crypto : undefined;
    const nodeRequire =  true &&
        __nccwpck_require__(84310).bind(module); <-- Note the 
    return {
        node: nodeRequire && !webCrypto ? require("crypto") : undefined,
        web: webCrypto
    };
})();

/***/ 84310:
/***/ ((module) => {

function webpackEmptyContext(req) {
	var e = new Error("Cannot find module '" + req + "'");
	e.code = 'MODULE_NOT_FOUND';
	throw e;
}
webpackEmptyContext.keys = () => ([]);
webpackEmptyContext.resolve = webpackEmptyContext;
webpackEmptyContext.id = 84310;
module.exports = webpackEmptyContext;

/***/ }),

This leads to the EA crash looping with this error:

Error: Cannot find module 'crypto'
    at Object.webpackEmptyContext (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:183577:10)
    at /Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:83270:43
    at Object.78777 (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:83273:3)
    at __nccwpck_require__ (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:183842:43)
    at Object.35681 (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:83194:17)
    at __nccwpck_require__ (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:183842:43)
    at Object.30038 (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:169615:16)
    at __nccwpck_require__ (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:183842:43)
    at Object.55944 (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:168123:14)
    at __nccwpck_require__ (/Users/christophersastropranoto/Documents/external-adapters-js/packages/sources/layer2-sequencer-health/bundle/index.js:183842:43) {
  code: 'MODULE_NOT_FOUND'
}

[HenryNguyen5]

I think webpack is trying to bundle crypto when it's a native module. You could try the following ncc flag: --external crypto.

If that doesn't work, I would try upgrading ncc to latest to see if it fixes the require statement.

[cds95]

I've tried both of those already and still no luck :(

[cds95]

I even tried building the js-ethereum-cryptography project directly and still see the issue.

[HenryNguyen5]

I’m not sure how important it is to not patch a package. But you could also abandon ncc and switch it up for something like swc or esbuild + do a prod only install for deps.

[krebernisak]

@cds95 we should investigate if we can remove 0.1.3 version altogether and move to v1

[cds95]

@krebernisak @HenryNguyen5 I've opened an issue in the js-ethereum-cryptography repo here.

Edit: I've been told to open another issue at NCC, which I have done here vercel/ncc#985

[boxhock]

Was a fix for this already merged in? Should we close this PR?