Make template functions generic with backwards compatibility #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function can create a `x509util.Certificate` from an x509.Certificate (used as a template). It also supports options, to provide a template, so that data can be set in the certificate. Currently a template is always required. An error will be returned when no template is provided.
hslatman
force-pushed
the
herman/alternative-generic-template-functions
branch
from
0460c07
to
9c0e6fc
Compare
|
Closing in favor of #248. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach to making the template functions generic, as done in #239, but now with backwards compatibility for users of the package.