Add --skip-csr-signature option
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a certificate for a public key backed by a KMS that doesn't allow the key to also be used for signing, or in cases where the private key isn't readily available to sign the CSR, `--skip-csr-signature` can be passed to skip signing the (internally used) CSR. This option is not compatible with `--csr`, because that requires a CSR with a valid signature to be produced.
github-actions
bot
added
the
needs triage
Instead of relying on a new implementation based on generics, smallstep/crypto#248 was created to have a minimal implementation for supporting signing public keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a certificate for a public key backed by a KMS that doesn't allow the key to also be used for signing, or in cases where the private key isn't readily available to sign the (internally used) CSR,
--skip-csr-signaturecan be passed to skip signing the (internally used) CSR.This option is not compatible with
--csr, because that requires a CSR with a valid signature to be produced.Note: this builds on the changes in #945 and depends on the changes in
smallstep/crypto#239 to be finalized. After merging the changes from smallstep/crypto#239smallstep/crypto#248.Will add example usage when updating with the latest
smallstep/crypto.