feat: Add cosign registry opts for provenance registry #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saisatishkarra
requested review from
asraa,
ianlewis,
laurentsimon and
kpk47
as code owners
saisatishkarra
force-pushed
the
feat/provenance-registry-co-opts
branch
from
62b953b
to
7923108
Compare
triggered on specification of COSIGN_REPOSITORY env Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
saisatishkarra
force-pushed
the
feat/provenance-registry-co-opts
branch
from
9362e42
to
12ad726
Compare
|
see comment |
|
Thanks. Let me know if you're OK with my latest comment slsa-framework/slsa-github-generator#3024 (comment) |
Sounds good to me!! lets get this merged and tested out against e2e in the main!! That should support the feature in the first place. As a second iteration we could an explicit variable in the verifier along side the environment variable |
laurentsimon
approved these changes
Jan 4, 2024
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
laurentsimon
approved these changes
Jan 4, 2024
laurentsimon
changed the title
ramonpetgrave64
pushed a commit
to ramonpetgrave64/slsa-verifier
that referenced
this pull request
Apr 10, 2024
…k#729) triggered on specification of COSIGN_REPOSITORY env --------- Signed-off-by: saisatishkarra <saisatish.karra@konghq.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggered on specification of COSIGN_REPOSITORY env