-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cosign registry opts for provenance registry #729
feat: Add cosign registry opts for provenance registry #729
Conversation
62b953b
to
7923108
Compare
triggered on specification of COSIGN_REPOSITORY env Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
9362e42
to
12ad726
Compare
see comment |
Thanks. Let me know if you're OK with my latest comment slsa-framework/slsa-github-generator#3024 (comment) |
Sounds good to me!! lets get this merged and tested out against e2e in the main!! That should support the feature in the first place. As a second iteration we could an explicit variable in the verifier along side the environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. let's just revert the README changes, since it will be obsolete in the next PR
Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
…k#729) triggered on specification of COSIGN_REPOSITORY env --------- Signed-off-by: saisatishkarra <saisatish.karra@konghq.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com> Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
triggered on specification of COSIGN_REPOSITORY env