-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Record vars in SLSA generators #3633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
15 tasks
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
ianlewis
requested review from
laurentsimon,
joshuagl,
kpk47 and
ramonpetgrave64
as code owners
May 14, 2024 21:05
ianlewis
commented
May 16, 2024
Signed-off-by: Ian Lewis <ianlewis@google.com>
ianlewis
changed the title
feat: Record vars in generators and Go builder
feat: Record vars in SLSA generators
May 16, 2024
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
ramonpetgrave64
approved these changes
May 17, 2024
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Records the GitHub vars context in the SLSA invocation in the generic generator and container generator.
The
vars
context is passed to the "builder" binary as a JSON blob via theGITHUB_VARS
environment variable. The values are then recorded in theinvocation.parameters.vars
field of the provenance predicate. Masking of inputs or vars is not supported.Note that the
vars
context is set to the variables for the repository that initiated the GitHub Actions run and not the reusable workflow's repository.Updates #1555
Testing Process
compile-generator: true
input must be set.invocation.parameters.vars
field in the resulting provenance. The vars should be recorded there.Checklist