fix: Update release docs #3589
Merged
fix: Update release docs #3589
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
mihaimaruseac
approved these changes
Apr 30, 2024
Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
mihaimaruseac
approved these changes
May 2, 2024
ianlewis
reviewed
May 7, 2024
| @@ -163,7 +163,7 @@ There is one integration test we cannot easily test "live", so we need to simula | |||
| using this command: | |||
| ```shell | |||
| sed -i "s/uses: slsa-framework\/slsa-github-generator\/\.github\/actions\/generate-builder@\(main\|v[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc\.[0-9]\+\)\?\)/uses: ${BUILDER_REPOSITORY/\//\\\/}\/.github\/actions\/generate-builder@${BUILDER_TAG}/" .github/workflows/builder_go_slsa3.yml | |||
| sed -i "s/uses: slsa-framework\/slsa-github-generator\/\.github\/actions\/generate-builder@\(main\|v[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc\.[0-9]\+\)\?\)/uses: ${BUILDER_REPOSITORY/\//\/}\/.github\/actions\/generate-builder@${BUILDER_TAG}/" .github/workflows/builder_go_slsa3.yml | |||
There was a problem hiding this comment.
Were these commands not working for some reason?
There was a problem hiding this comment.
Not on my machine
I totally sympathize with this. I think the release process is entirely too manual but it's difficult to automate. Ideally we wouldn't need to do this but I think we need to iterate to improve as best we can. |
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
ianlewis
approved these changes
May 8, 2024
ramonpetgrave64
added a commit
to slsa-framework/slsa-verifier
that referenced
this pull request
Jun 27, 2024
Making the `download-artifacts.sh` script be more useful. Before, it would error upon seeing some zip files that it doesn't expect to be in the GH release. I think the script is just a bit outdated. But for now, I think we should bypass that, since the script is already written to know which of the final files within the archives are actually needed. related PR slsa-framework/slsa-github-generator#3589 Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few fixes and additions to the release docs.
sedcommandsrelated PR slsa-framework/slsa-verifier#761
Testing Process
Manual testing locally.
Checklist