Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break: Revert "chore: Revert "fix: upload-artifact and download-artifact v4"" #3499

Merged
merged 2 commits into from
Apr 3, 2024
Merged

break: Revert "chore: Revert "fix: upload-artifact and download-artifact v4"" #3499

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f2ca0
Revert "chore: Revert "fix: upload-artifact and download-artifact v4"…
ramonpetgrave64 Apr 2, 2024
897e28c
differentiate the provenance names, so we don't attempt to overwrite
ramonpetgrave64 Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pre-submit.e2e.generic.default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
# echo "2e0390eb024a52963db7b95e84a9c2b12c004054a7bad9a97ec0c7c89d4681d2 binary-name" | base64 -w0
base64-subjects: "MmUwMzkwZWIwMjRhNTI5NjNkYjdiOTVlODRhOWMyYjEyYzAwNDA1NGE3YmFkOWE5N2VjMGM3Yzg5ZDQ2ODFkMiAgICBiaW5hcnktbmFtZQo="
compile-generator: true
provenance-name: build.intoto.jsonl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good catch! Were these effectively colluding with each other?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, which upload-artifact@v4 doesn't allow anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, I hadn't realized that this particular test was also failing.


verify:
# NOTE: this name is used as the status check name and by protected
Expand Down Expand Up @@ -66,6 +67,7 @@ jobs:
base64-subjects: "MmUwMzkwZWIwMjRhNTI5NjNkYjdiOTVlODRhOWMyYjEyYzAwNDA1NGE3YmFkOWE5N2VjMGM3Yzg5ZDQ2ODFkMiAgICBiaW5hcnktbmFtZQo="
compile-generator: true
continue-on-error: true
provenance-name: build-continue-no-error.intoto.jsonl

verify-continue-no-error:
# NOTE: this name is used as the status check name and by protected
Expand Down Expand Up @@ -96,6 +98,7 @@ jobs:
base64-subjects: "invalid base64 subjects"
compile-generator: true
continue-on-error: true
provenance-name: build-continue-invalid-subjects.intoto.jsonl

verify-continue-invalid-subjects:
# NOTE: this name is used as the status check name and by protected
Expand Down