Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breaking): remove attestation-name input and output #3456

Conversation

ramonpetgrave64
Copy link
Collaborator

Summary

Testing Process

  • We have existing PR Check workflows that do call the generic-genertor wth the correct parameters
  • example-package e2e2 tests have already been updated to use the new parameter and are already passing.

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review March 27, 2024 16:16
@ramonpetgrave64 ramonpetgrave64 changed the title Revert: chore: Revert "fix: remove attestation-name input and output" feat: Revert: chore: Revert "fix: remove attestation-name input and output" Mar 27, 2024
@laurentsimon laurentsimon changed the title feat: Revert: chore: Revert "fix: remove attestation-name input and output" fix: remove attestation-name input and output Mar 27, 2024
@laurentsimon laurentsimon changed the title fix: remove attestation-name input and output feat(breaking): remove attestation-name input and output Mar 27, 2024
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@laurentsimon laurentsimon enabled auto-merge (squash) March 27, 2024 16:27
@laurentsimon
Copy link
Collaborator

linter is complaining

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
@laurentsimon laurentsimon merged commit 2512315 into slsa-framework:main Mar 27, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] attestation-name deprecation warning [bug] Opaque failure in final step
2 participants