-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert before release #3400
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonpetgrave64
requested review from
laurentsimon,
joshuagl and
kpk47
as code owners
March 20, 2024 15:53
I don't think that's a breaking change, right? |
This reverts commit e64a212. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit a66d8c0. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 5f89252. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 52372c6. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit b097318. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit a39709d. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 0f54290. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 6c0e4f6. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit b54dfc3. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit 7bf88f9. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
This reverts commit ab7dcb6. Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
ramonpetgrave64
force-pushed
the
revert-before-release
branch
from
March 20, 2024 15:58
e7b7cc6
to
93d691a
Compare
Ignore this comment, I read the description and that would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For this emergency release, following @kpk47 's strategy to revert all changes from the time of v1.9.0 up to this morning's fix containing the sgistore update
#3393 (comment)
Testing Process
...
Checklist