Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking reverting breaking changes before new emergency release #3393

Closed
ramonpetgrave64 opened this issue Mar 20, 2024 · 6 comments
Closed
Labels
status:triage Issue that has not been triaged type:bug Something isn't working

Comments

@ramonpetgrave64
Copy link
Collaborator

tracking revert PRs before the next emergency release

@ramonpetgrave64
Copy link
Collaborator Author

getting some errors when trying to revert some PRs
image

@ramonpetgrave64
Copy link
Collaborator Author

ramonpetgrave64 commented Mar 20, 2024

last release was at v1.9.0 07e64b6

@kpk47
Copy link
Contributor

kpk47 commented Mar 20, 2024

Can we just create a new release branch from the last release date and apply the sigstore fix to that? We won't have the chore releases since then, but we'll at least have the sigstore fix.

@ramonpetgrave64
Copy link
Collaborator Author

@kpk sounds good, we can bramch from
07e64b6
and then apply the fixes from
#3355

But I think there may be an adversarial test for releasing from a non-main branch.

@laurentsimon
Copy link
Collaborator

If we revert:

#3313 (I'll send a PR)
Need to update the CHANGELOG for Hayden's PR
example-package revert the v3->v4 action

I'm more confident doing this in the main branch than in a different branch. The e2e tests don't work on different branch. There's just one PR left to revert #3313

@kpk47
Copy link
Contributor

kpk47 commented Mar 20, 2024

Okay, sounds good. Let's go with your plan.

I've got a release branch together already, so we've got that in case we need it for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage Issue that has not been triaged type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants