Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #3220

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Refactor #3220

merged 5 commits into from
Nov 7, 2022

Conversation

amirkhodabande
Copy link
Contributor

No description provided.

akrabat
akrabat requested changes Nov 5, 2022
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the constant name, please rebase against 4.x and fix conflicts.

@akrabat akrabat added the pending response Waiting on a response from the original poster label Nov 5, 2022
@amirkhodabande
Copy link
Contributor Author

In addition to the constant name, please rebase against 4.x and fix conflicts.

@amirkhodabande amirkhodabande reopened this Nov 6, 2022
@amirkhodabande
Merge branch '4.x' into refactor
2739c2c 
# Conflicts:
#	tests/Middleware/MethodOverrideMiddlewareTest.php
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.36% when pulling 2739c2c on amirkhodabande:refactor into b0f4ca3 on slimphp:4.x.

akrabat
akrabat approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@akrabat akrabat merged commit 75d5613 into slimphp:4.x Nov 7, 2022
@akrabat akrabat added this to the 4.12.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat approved these changes

Assignees
No one assigned
Labels
pending response Waiting on a response from the original poster
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amirkhodabande @coveralls @akrabat