Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(security): require access checks to pass before running unit tests #279

Merged
merged 2 commits into from
Jan 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 19 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ on:
- main

jobs:
unit_tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- run: npm ci && npm run build
- run: npm test

# Note: The `pull_request_target` event provides access to repository secrets!
#
# This is required to run the integration tests on PRs from forked branches.
# Any job checking out pull_request.head.sha should require the access_check.
#
# Actions require collaborator approval to start and might require a re-run.
# The proposed changes should be reviewed before approving any workflow jobs.
#
# Reference: https://michaelheap.com/access-secrets-from-forks/
access_check:
runs-on: ubuntu-latest
steps:
Expand All @@ -25,6 +25,16 @@ jobs:
echo "Action was not triggered by an organization member. Exiting now."
exit 1

unit_tests:
runs-on: ubuntu-latest
needs: access_check
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- run: npm ci && npm run build
- run: npm test

integration_test_botToken:
runs-on: ubuntu-latest
needs: access_check
Expand Down