Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: clarify limitations to workflow builder approach #228

Merged
merged 1 commit into from Jul 21, 2023

Conversation

ryan-williams
Copy link
Contributor

Summary

The previously docs described "Technique 1" as "the recommended way to use this action", but that doesn't make sense given it doesn't support any text or message formatting (cf. #192 (comment)). This attempts to make that limitation clearer, cc @seratch.

Requirements (place an x in each [ ])

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @ryan-williams to sign the Salesforce Inc. Contributor License Agreement.

@misscoded misscoded added the documentation Improvements or additions to documentation label Jul 20, 2023
@misscoded
Copy link

Hi @ryan-williams! Thanks for the submission. Since @seratch was part of the original discussion that this change cites, awaiting his confirmation that this change is good to go prior to merging.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change. LGTM

@seratch seratch merged commit 10d6bcd into slackapi:main Jul 21, 2023
2 of 6 checks passed
@ryan-williams ryan-williams deleted the patch-1 branch August 3, 2023 12:53
PhuongTMR pushed a commit to PhuongTMR/slack-github-action that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants