Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for bot token and webhook url length #124

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

koki-develop
Copy link
Contributor

Summary

Fixed #123

Requirements (place an x in each [ ])

@koki-develop koki-develop marked this pull request as ready for review September 5, 2022 08:30
@seratch seratch self-assigned this Sep 5, 2022
@seratch seratch added the bug Something isn't working label Sep 5, 2022
@seratch seratch added this to the 1.22 milestone Sep 5, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@seratch
Copy link
Member

seratch commented Sep 5, 2022

The integration tests using env variables are failing. Need to investigate later

@koki-develop
Copy link
Contributor Author

Hmmm...

PRs created from Forked repositories cannot see the secret.
As a result, empty strings are passed to SLACK_BOT_TOKEN and SLACK_WEBHOOK_URL on the integration test.
This PR added a check for empty string, which caused the integration test to fail 🤔

screenshot

@seratch
Copy link
Member

seratch commented Sep 6, 2022

The test log console does not display the env variable values for better security.

@stevengill Do you have any thoughts on this? I think that env variables should be correctly set but am still unsure why the length validation that is added in this PR cause the test failures.

@koki-develop
Copy link
Contributor Author

koki-develop commented Sep 6, 2022

@seratch

The test log console does not display the env variable values for better security.

Yes, in the GitHub Actions log, the secret will appear as ***, like:

log

The screenshot attached to the previous comment does not even show ***.
This means that an empty value has been set.

@koki-develop
Copy link
Contributor Author

As described in this document, secrets cannot be referenced from workflows triggered from a forked repository.

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow

For reference, if you want to refer to secrets from workflows triggered from a forked repository, you need to use the pull_request_target workflow trigger.
However, this may be dangerous from a security standpoint, so care should be taken.

Due to the dangers inherent to automatic processing of PRs, GitHub’s standard pull_request workflow trigger by default prevents write permissions and secrets access to the target repository. However, in some scenarios such access is needed to properly process the PR. To this end the pull_request_target workflow trigger was introduced.

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

@filmaj filmaj modified the milestones: 1.22, 1.23 Sep 13, 2022
@seratch seratch modified the milestones: 1.23, 1.24 Oct 11, 2022
@stevengill stevengill merged commit 0591a83 into slackapi:main Oct 25, 2022
TylerJang27 pushed a commit to trunk-io/plugins that referenced this pull request May 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
|
[@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`18.16.1` ->
`18.16.14`](https://renovatebot.com/diffs/npm/@types%2fnode/18.16.1/18.16.14)
|
[![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.16.14/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.16.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.16.14/compatibility-slim/18.16.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/18.16.14/confidence-slim/18.16.1)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint)
| [`5.59.1` ->
`5.59.7`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.59.1/5.59.7)
|
[![age](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.7/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.7/compatibility-slim/5.59.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2feslint-plugin/5.59.7/confidence-slim/5.59.1)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint)
| [`5.59.1` ->
`5.59.7`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.59.1/5.59.7)
|
[![age](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.7/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.7/compatibility-slim/5.59.1)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@typescript-eslint%2fparser/5.59.7/confidence-slim/5.59.1)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
| [eslint](https://eslint.org)
([source](https://togithub.com/eslint/eslint)) | [`8.39.0` ->
`8.41.0`](https://renovatebot.com/diffs/npm/eslint/8.39.0/8.41.0) |
[![age](https://badges.renovateapi.com/packages/npm/eslint/8.41.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/eslint/8.41.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/eslint/8.41.0/compatibility-slim/8.39.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/eslint/8.41.0/confidence-slim/8.39.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
| [github/codeql-action](https://togithub.com/github/codeql-action) |
`v2.3.0` -> `v2.3.3` |
[![age](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.3.3/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.3.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.3.3/compatibility-slim/v2.3.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/github-tags/github%2fcodeql-action/v2.3.3/confidence-slim/v2.3.0)](https://docs.renovatebot.com/merge-confidence/)
| action | patch |
| [semver](https://togithub.com/npm/node-semver) | [`7.5.0` ->
`7.5.1`](https://renovatebot.com/diffs/npm/semver/7.5.0/7.5.1) |
[![age](https://badges.renovateapi.com/packages/npm/semver/7.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/semver/7.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/semver/7.5.1/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/semver/7.5.1/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[slackapi/slack-github-action](https://togithub.com/slackapi/slack-github-action)
| `v1.23.0` -> `v1.24.0` |
[![age](https://badges.renovateapi.com/packages/github-tags/slackapi%2fslack-github-action/v1.24.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/github-tags/slackapi%2fslack-github-action/v1.24.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/github-tags/slackapi%2fslack-github-action/v1.24.0/compatibility-slim/v1.23.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/github-tags/slackapi%2fslack-github-action/v1.24.0/confidence-slim/v1.23.0)](https://docs.renovatebot.com/merge-confidence/)
| action | minor |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v5.59.7`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5597-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5596v5597-2023-05-22)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.6...v5.59.7)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)

###
[`v5.59.6`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5596-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5595v5596-2023-05-15)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.5...v5.59.6)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)

###
[`v5.59.5`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5595-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5594v5595-2023-05-08)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.2...v5.59.5)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)

###
[`v5.59.2`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5592-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5591v5592-2023-05-01)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.1...v5.59.2)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v5.59.7`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5597-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5596v5597-2023-05-22)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.6...v5.59.7)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

###
[`v5.59.6`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5596-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5595v5596-2023-05-15)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.5...v5.59.6)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

###
[`v5.59.5`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5595-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5594v5595-2023-05-08)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.2...v5.59.5)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

###
[`v5.59.2`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5592-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5591v5592-2023-05-01)

[Compare
Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.59.1...v5.59.2)

**Note:** Version bump only for package
[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)

</details>

<details>
<summary>eslint/eslint</summary>

### [`v8.41.0`](https://togithub.com/eslint/eslint/releases/tag/v8.41.0)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v8.40.0...v8.41.0)

#### Features

-
[`880a431`](https://togithub.com/eslint/eslint/commit/880a4317b949e575a4a6c5e8baaba1eea7674cc6)
feat: change default ignore pattern to `**/node_modules/` in flat config
([#&#8203;17184](https://togithub.com/eslint/eslint/issues/17184))
(Milos Djermanovic)
-
[`8bf5505`](https://togithub.com/eslint/eslint/commit/8bf550594fca6d29fab1a3453e701c1a457767e1)
feat: expose `shouldUseFlatConfig`
([#&#8203;17169](https://togithub.com/eslint/eslint/issues/17169))
(Connor Prussin)

#### Bug Fixes

-
[`4f5440d`](https://togithub.com/eslint/eslint/commit/4f5440db631707b17140c4e5cc7beb223afbd2b9)
fix: incorrect warning message for ignored dotfiles
([#&#8203;17196](https://togithub.com/eslint/eslint/issues/17196))
(Milos Djermanovic)
-
[`94da96c`](https://togithub.com/eslint/eslint/commit/94da96cbf0fb2bb6694fa2e757eb1b3e74c40db7)
fix: unify `LintMessage` type
([#&#8203;17076](https://togithub.com/eslint/eslint/issues/17076))
(Brandon Mills)
-
[`0c415cd`](https://togithub.com/eslint/eslint/commit/0c415cda5d76dbe5120ab9f3c4c81320538e35f0)
fix: validate `ignorePatterns` constructor option in `FlatESLint` class
([#&#8203;17139](https://togithub.com/eslint/eslint/issues/17139))
(Milos Djermanovic)
-
[`9682d66`](https://togithub.com/eslint/eslint/commit/9682d669e4ee8641293914e21679f40fee8bc354)
fix: switch `grapheme-splitter` to `graphemer`
([#&#8203;17160](https://togithub.com/eslint/eslint/issues/17160))
(fisker Cheung)

#### Documentation

-
[`7709b14`](https://togithub.com/eslint/eslint/commit/7709b14e18ad4e11c1119ed6575454243b8e7084)
docs: Update README (GitHub Actions Bot)
-
[`7f183e0`](https://togithub.com/eslint/eslint/commit/7f183e020579380fa57473caaf9ed154470c25b3)
docs: Update triage process description
([#&#8203;17157](https://togithub.com/eslint/eslint/issues/17157))
(Nicholas C. Zakas)
-
[`b68346b`](https://togithub.com/eslint/eslint/commit/b68346b290d55324e73868ca42b3854157b27375)
docs: fix license to reflect relicensing of jshint
([#&#8203;17165](https://togithub.com/eslint/eslint/issues/17165))
(Stefan Bischof)

#### Chores

-
[`f43216a`](https://togithub.com/eslint/eslint/commit/f43216a8c77ab6cf1d0823978e8c728786b4cba7)
chore: upgrade
[@&#8203;eslint/js](https://togithub.com/eslint/js)[@&#8203;8](https://togithub.com/8).41.0
([#&#8203;17200](https://togithub.com/eslint/eslint/issues/17200))
(Milos Djermanovic)
-
[`95c3007`](https://togithub.com/eslint/eslint/commit/95c300780a1cfd9ad680bc78850542eb55d7fbf4)
chore: package.json update for
[@&#8203;eslint/js](https://togithub.com/eslint/js) release (ESLint
Jenkins)
-
[`ddc5291`](https://togithub.com/eslint/eslint/commit/ddc5291debd90ff476e17c532af7577e26720b91)
chore: don't use deprecated `context` methods in `ast-utils` tests
([#&#8203;17194](https://togithub.com/eslint/eslint/issues/17194))
(Milos Djermanovic)
-
[`b1516db`](https://togithub.com/eslint/eslint/commit/b1516db51514032ed06e1425c4b1f955238dc682)
chore: Fix return type of `findFlatConfigFile`
([#&#8203;17161](https://togithub.com/eslint/eslint/issues/17161))
(Milos Djermanovic)
-
[`918b0fd`](https://togithub.com/eslint/eslint/commit/918b0fd21723e84bd7acb17942a36606f1d8360a)
perf: Store indent descriptors in a plain array
([#&#8203;17148](https://togithub.com/eslint/eslint/issues/17148))
(Francesco Trotta)
-
[`4caa344`](https://togithub.com/eslint/eslint/commit/4caa34449555d8a680222ec2049d97c59476c11e)
refactor: locateConfigFileToUse returns an Error object
([#&#8203;17159](https://togithub.com/eslint/eslint/issues/17159)) (唯然)

### [`v8.40.0`](https://togithub.com/eslint/eslint/releases/tag/v8.40.0)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v8.39.0...v8.40.0)

#### Features

-
[`5db7808`](https://togithub.com/eslint/eslint/commit/5db7808139c1f2172797285a0700f01644bda254)
feat: improve flat config errors for invalid rule options and severities
([#&#8203;17140](https://togithub.com/eslint/eslint/issues/17140)) (Josh
Goldberg ✨)
-
[`f5574dc`](https://togithub.com/eslint/eslint/commit/f5574dc739fcc74a7841217ba1f31cce02bee1ff)
feat: Add findConfigFile() method to FlatESLint
([#&#8203;17142](https://togithub.com/eslint/eslint/issues/17142))
(Nicholas C. Zakas)
-
[`e52b98b`](https://togithub.com/eslint/eslint/commit/e52b98bf25d882da4efd5559ce5974b6697cf701)
feat: add `sourceCode` property to the rule context
([#&#8203;17107](https://togithub.com/eslint/eslint/issues/17107))
(Nitin Kumar)
-
[`1468f5b`](https://togithub.com/eslint/eslint/commit/1468f5b640cfa6fdd8a5ec895337f692def2780b)
feat: add `physicalFilename` property to the rule context
([#&#8203;17111](https://togithub.com/eslint/eslint/issues/17111))
(Nitin Kumar)
-
[`0df4d4f`](https://togithub.com/eslint/eslint/commit/0df4d4f658c214e51310a986c03d44d34ceae3ec)
feat: add `cwd` to rule context
([#&#8203;17106](https://togithub.com/eslint/eslint/issues/17106))
(Nitin Kumar)
-
[`52018f2`](https://togithub.com/eslint/eslint/commit/52018f21c19b3e461cae32843cddd17ed42f19cd)
feat: add `filename` property to the rule context
([#&#8203;17108](https://togithub.com/eslint/eslint/issues/17108))
(Nitin Kumar)
-
[`559ff4e`](https://togithub.com/eslint/eslint/commit/559ff4e4bc54a8b6e6b54825d83c532d724204b3)
feat: add new `omitLastInOneLineClassBody` option to the `semi` rule
([#&#8203;17105](https://togithub.com/eslint/eslint/issues/17105))
(Nitin Kumar)

#### Bug Fixes

-
[`f076e54`](https://togithub.com/eslint/eslint/commit/f076e54ecdb0fae70d9b43ad6888606097beef97)
fix: Ensure FlatESLint#findConfigFile() doesn't throw.
([#&#8203;17151](https://togithub.com/eslint/eslint/issues/17151))
(Nicholas C. Zakas)

#### Documentation

-
[`e980bf3`](https://togithub.com/eslint/eslint/commit/e980bf38cf441f2eb29c458b93df77dc0111b391)
docs: Update README (GitHub Actions Bot)
-
[`e92a6fc`](https://togithub.com/eslint/eslint/commit/e92a6fc7ed2a427f5e95f4b3a1c21d71553c97ee)
docs: Update README (GitHub Actions Bot)
-
[`af5fe64`](https://togithub.com/eslint/eslint/commit/af5fe64c398c9bd4206c3c6c1ade81768b291031)
docs: Fix custom rule schema docs
([#&#8203;17115](https://togithub.com/eslint/eslint/issues/17115)) (Adam
Jones)
-
[`4a352a9`](https://togithub.com/eslint/eslint/commit/4a352a957ba9e721bec9f6f403b419a22b0ec423)
docs: explain how to include predefined globals
([#&#8203;17114](https://togithub.com/eslint/eslint/issues/17114))
(Marcus Wyatt)
-
[`5ea15d9`](https://togithub.com/eslint/eslint/commit/5ea15d92ee358e8f3f652c94c019cac96aaec651)
docs: add mastodon link in readme
([#&#8203;17110](https://togithub.com/eslint/eslint/issues/17110)) (唯然)

#### Chores

-
[`4053004`](https://togithub.com/eslint/eslint/commit/4053004c951813473d1c43f9f9959a9a3484242f)
chore: upgrade
[@&#8203;eslint/js](https://togithub.com/eslint/js)[@&#8203;8](https://togithub.com/8).40.0
([#&#8203;17156](https://togithub.com/eslint/eslint/issues/17156))
(Milos Djermanovic)
-
[`50fed1d`](https://togithub.com/eslint/eslint/commit/50fed1da4449ad7ecbb558294438273cfce603d4)
chore: package.json update for
[@&#8203;eslint/js](https://togithub.com/eslint/js) release (ESLint
Jenkins)
-
[`4c7a170`](https://togithub.com/eslint/eslint/commit/4c7a170b04c5a746e401bef7ce79766ff66a1168)
chore: upgrade
[@&#8203;eslint/eslintrc](https://togithub.com/eslint/eslintrc)[@&#8203;2](https://togithub.com/2).0.3
([#&#8203;17155](https://togithub.com/eslint/eslint/issues/17155))
(Milos Djermanovic)
-
[`e80b7cc`](https://togithub.com/eslint/eslint/commit/e80b7cce640b60c00802148dbb51d03c7223afa9)
chore: upgrade espree@9.5.2
([#&#8203;17154](https://togithub.com/eslint/eslint/issues/17154))
(Milos Djermanovic)
-
[`ce3ac91`](https://togithub.com/eslint/eslint/commit/ce3ac91b510576e2afba1657aa5f09e162b4ab07)
chore: upgrade eslint-visitor-keys@3.4.1
([#&#8203;17153](https://togithub.com/eslint/eslint/issues/17153))
(Milos Djermanovic)
-
[`9094d79`](https://togithub.com/eslint/eslint/commit/9094d79fb42c0ebb6100426a3f2f851e8d42a0ee)
chore: add `latest/` to `meta.docs.url` in all core rules
([#&#8203;17136](https://togithub.com/eslint/eslint/issues/17136))
(Milos Djermanovic)
-
[`d85efad`](https://togithub.com/eslint/eslint/commit/d85efad655deacc0dc3fdbbace33307094c3b91b)
perf: don't use `grapheme-splitter` on ASCII strings in key-spacing rule
([#&#8203;17122](https://togithub.com/eslint/eslint/issues/17122))
(Milos Djermanovic)

</details>

<details>
<summary>github/codeql-action</summary>

###
[`v2.3.3`](https://togithub.com/github/codeql-action/compare/v2.3.2...v2.3.3)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.3.2...v2.3.3)

###
[`v2.3.2`](https://togithub.com/github/codeql-action/compare/v2.3.1...v2.3.2)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.3.1...v2.3.2)

###
[`v2.3.1`](https://togithub.com/github/codeql-action/compare/v2.3.0...v2.3.1)

[Compare
Source](https://togithub.com/github/codeql-action/compare/v2.3.0...v2.3.1)

</details>

<details>
<summary>npm/node-semver</summary>

###
[`v7.5.1`](https://togithub.com/npm/node-semver/blob/HEAD/CHANGELOG.md#&#8203;751-httpsgithubcomnpmnode-semvercomparev750v751-2023-05-12)

[Compare
Source](https://togithub.com/npm/node-semver/compare/v7.5.0...v7.5.1)

##### Bug Fixes

-
[`d30d25a`](https://togithub.com/npm/node-semver/commit/d30d25a5c1fb963c3cc9178cb1769fe45e4a3cab)
[#&#8203;559](https://togithub.com/npm/node-semver/pull/559) show type
on invalid semver error
([#&#8203;559](https://togithub.com/npm/node-semver/issues/559))
([@&#8203;tjenkinson](https://togithub.com/tjenkinson))

</details>

<details>
<summary>slackapi/slack-github-action</summary>

###
[`v1.24.0`](https://togithub.com/slackapi/slack-github-action/releases/tag/v1.24.0):
Slack Send V1.24.0

[Compare
Source](https://togithub.com/slackapi/slack-github-action/compare/v1.23.0...v1.24.0)

##### What's Changed

- Add in testing instructions for maintainer's guide and standardize
bullet point punctuation by
[@&#8203;hello-ashleyintech](https://togithub.com/hello-ashleyintech) in
[slackapi/slack-github-action#140
- Added checks for bot token and webhook url length by
[@&#8203;koki-develop](https://togithub.com/koki-develop) in
[slackapi/slack-github-action#124
- Add channel_id output parameter by
[@&#8203;maso7](https://togithub.com/maso7) in
[slackapi/slack-github-action#149
-
\[[#&#8203;171](https://togithub.com/slackapi/slack-github-action/issues/171)]
Update Technique 2 to use Actions context instead of values property by
[@&#8203;mwbrooks](https://togithub.com/mwbrooks) in
[slackapi/slack-github-action#172
- Fix interpolation of variables in file-based payloads by
[@&#8203;filmaj](https://togithub.com/filmaj) in
[slackapi/slack-github-action#200
- Update README.md with variable usage and links to example workflows by
[@&#8203;filmaj](https://togithub.com/filmaj) in
[slackapi/slack-github-action#201

##### New Contributors

- [@&#8203;koki-develop](https://togithub.com/koki-develop) made their
first contribution in
[slackapi/slack-github-action#124
- [@&#8203;maso7](https://togithub.com/maso7) made their first
contribution in
[slackapi/slack-github-action#149
- [@&#8203;mwbrooks](https://togithub.com/mwbrooks) made their first
contribution in
[slackapi/slack-github-action#172
- [@&#8203;hnarimiya](https://togithub.com/hnarimiya) made their first
contribution in
[slackapi/slack-github-action#200

**Full Changelog**:
slackapi/slack-github-action@v1.23.0...v1.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/trunk-io/plugins).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuOTguMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Kurt-von-Laven
Copy link

Kurt-von-Laven commented May 24, 2023

This is a pretty bad experience for security-conscious users who receive PRs from forks and aren't willing to use pull_request_target. Before, there were simply no notifications from forks, which was a feature in our case. After, CI fails on any PR from a fork, which is a breaking change in our case because we use Forking Renovate for dependency bumps.

mtzguido added a commit to mtzguido/everest that referenced this pull request Jun 13, 2023
Sigh, to avoid errors if the token is not present, as in forked repos.
See slackapi/slack-github-action#124.
mtzguido added a commit to project-everest/everest that referenced this pull request Jun 13, 2023
Sigh, to avoid errors if the token is not present, as in forked repos.
See slackapi/slack-github-action#124.
mtzguido added a commit to mtzguido/everest that referenced this pull request Jun 19, 2023
Sigh, to avoid errors if the token is not present, as in forked repos.
See slackapi/slack-github-action#124.
@sarisia
Copy link

sarisia commented Aug 28, 2023

Since this PR changes current behaviour which just skips for missing / invalid tokens, it would be helpful to consider this as breaking change and bump major version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing an empty token or webhook url does not cause an error
6 participants