Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose useful functions #1955

Merged

Conversation

WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Sep 20, 2023

Summary

The goal of this PR is to export some helper function that could be useful for developers implementing their own authorization flow.

This resolves #1950

A user will be able to use these function as follows

const { isBodyWithTypeEnterpriseInstall, isEventTypeToSkipAuthorize } = require("@slack/bolt/dist/helpers");

Note: these helper functions are not exported from the index.ts file and should be considered unstable by the end user (minimal breaking change is expected for these functions in the future)

Requirements (place an x in each [ ])

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality semver:patch labels Sep 20, 2023
@WilliamBergamin WilliamBergamin self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1955 (133c89d) into main (51ee0b5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
+ Coverage   82.18%   82.21%   +0.03%     
==========================================
  Files          18       18              
  Lines        1521     1524       +3     
  Branches      436      438       +2     
==========================================
+ Hits         1250     1253       +3     
  Misses        175      175              
  Partials       96       96              
Files Changed Coverage Δ
src/App.ts 83.41% <100.00%> (-0.42%) ⬇️
src/helpers.ts 85.71% <100.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WilliamBergamin WilliamBergamin merged commit 7e59dba into slackapi:main Sep 21, 2023
8 checks passed
@WilliamBergamin WilliamBergamin deleted the expose-useful-functions branch September 21, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export useful functions from app.ts
2 participants