Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload code coverage reports using the Codecov GitHub Action #1937

Merged
merged 3 commits into from Aug 28, 2023

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Aug 28, 2023

Summary

This PR replaces the codecov package, which has been deprecated, with the Codecov GitHub Action to hopefully report the uploaded coverage statuses.

Requirements

@zimeg zimeg added semver:patch tests M-T: Testing work only dependencies Pull requests that update a dependency file labels Aug 28, 2023
@zimeg zimeg added this to the 3.14.0 milestone Aug 28, 2023
@zimeg zimeg self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1937 (1215aa7) into main (1d8a51b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          18       18           
  Lines        1521     1521           
  Branches      436      436           
=======================================
  Hits         1250     1250           
  Misses        175      175           
  Partials       96       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've been meaning to do this for a while, and I think I'll follow what we end up settling on in this repo for the node-slack-sdk projects while I'm mucking around in there, but, one thing I noticed is, are we running the coverage report generation for each node version in the testing matrix? I believe we are (and I guess we did this all along!) but maybe we can run it on just one node version? Not sure if it makes a difference or not, but I'd probably default to only running the coverage report using the latest stable version of node we support.

@zimeg
Copy link
Member Author

zimeg commented Aug 28, 2023

@filmaj Totally right that we're uploading reports for each version! Honestly not sure what coverage was being reported with this, so nice catch.

Updated this to only upload with the latest version as I agree this is a good call. Tests will still pass or fail on any version, and coverage should be similar between versions, but no more uploading coverage for each version!

@zimeg zimeg requested a review from filmaj August 28, 2023 18:55
@zimeg zimeg merged commit c1abf6e into slackapi:main Aug 28, 2023
8 checks passed
@zimeg zimeg deleted the codecov branch August 28, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file semver:patch tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants