Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: workflows.stepCompleted and workflwows.stepFailed support #1060

Merged
merged 3 commits into from
Jul 24, 2022

Conversation

nakatanakatana
Copy link
Contributor

@nakatanakatana nakatanakatana commented May 6, 2022

add support for the workflows.stepCompleted and workflows.stepFailed

using this API to indicate Slack that the workflow step is complete

@kanata2
Copy link
Member

kanata2 commented May 17, 2022

Please add description for your changes.

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label May 19, 2022
@nakatanakatana nakatanakatana changed the title add: workflows.stepCompleted and workflwows.stepFailed add: workflows.stepCompleted and workflwows.stepFailed support May 24, 2022
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jun 6, 2022
@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jun 12, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nakatanakatana nakatanakatana force-pushed the add_workflows_methods branch from 9d70564 to f55b7c9 Compare June 14, 2022 23:42
@kanata2 kanata2 added needs review and removed feedback given When a review has been conducted and awaiting the response from the comitter(s) labels Jul 5, 2022
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. I commented on one point.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kanata2 kanata2 merged commit 74e583e into slack-go:master Jul 24, 2022
@kanata2
Copy link
Member

kanata2 commented Jul 25, 2022

Released! https://github.com/slack-go/slack/releases/tag/v0.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants