Added Details field to Audit event entries #1047
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the optional `details` field for the audit events. As there aren't details what all of the sub-fields are, adding different fields that we've seen in our logs.
Added Details field to Audit event entries
|
@JustinJudd Could you run |
|
Sorry about that. Formatted. |
kanata2
reviewed
Apr 16, 2022
There was a problem hiding this comment.
I couldn't confirm some fields in Java SDK's implementation.
- policy_name
- authentication_mode
- entity_ids
- succeeded_users
- failed_users
As I mentioned in #1038, we don't have a way to verify Enterprise Grid API's behavior.
If these fields are not essential to your use case, we can merge them as soon as you remove them. How about it?
kanata2
added
the
feedback given
Co-authored-by: Naoki Kanatani <k12naoki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the optional details field for the audit events. As there aren't details what all of the sub-fields are, adding different fields that we've seen in our logs.