New issue

Jump to bottom

[experimental] introduction of Slack workflow steps #1027

Merged

zchee merged 35 commits into slack-go:master from SteffenMahler:workflow-steps

Mar 11, 2022

+6,030 −792

SteffenMahler commented Feb 4, 2022

New experimental feature "Slack workflow steps" added

make pr-prep
tests included
dependency github.com/google/go-cmp/cmp for test added
example App included

Steffen Mahler added 5 commits

January 30, 2022 16:11


          introduce workflow step app functionality

636f906


          tests for workflowStep added

b5814ae


          example workflowStep app added

b13d00e


          readme improved

7f4937f


          unused variable in example removed, switch line indention to tabulator

Member

kanata2 commented Feb 8, 2022 •

edited

Loading

Thanks! I'll confirm later 👀

BTW, please use workflow_step instead of workflowStep in dir name and file name.

Steffen Mahler and others added 6 commits

February 8, 2022 07:57


          using snake case for new directory and file

0a59db7


          Add refresh_token and token_type to OAuthV2Response fields

4d6e826


          Merge pull request slack-go#1030 from hidenami-i/master

9cad061

Add refresh_token and token_type to OAuthV2Response fields


          all: add new //go:build lines

7f6b224

$ go version
go version go1.17.7 darwin/amd64

$ make fmt

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          all: remove github.com/pkg/errors dependency

eaf6740

The github.com/pkg/errors package has been deprecated.

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          Merge pull request slack-go#1032 from zchee/go117-buildtag

1bc0bcc

all: add new //go:build lines

Member

kanata2 commented Feb 13, 2022

@SteffenMahler
Could you confirm this?
https://github.com/slack-go/slack/runs/5167540820

kanata2 added the feedback given label

zchee and others added 2 commits

February 13, 2022 22:00


          vendor: run go mod vendor

86cef73

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          Merge pull request slack-go#1033 from zchee/remove-pkg-errors-deps

bbab81d

all: remove github.com/pkg/errors dependency

Author

SteffenMahler commented Feb 14, 2022

@kanata2
Yes, I will check the linter problem soon and let you know when I am done.

zchee and others added 4 commits

February 14, 2022 20:52


          messageID: add benchmark for NewSafeID

c01cb38

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          messageID: optimize NewSafeID using atomic instead of mutex lock

fb30ed3

name                  old time/op    new time/op    delta
NewSafeID-20            13.9ns ± 2%     7.5ns ± 1%  -46.16%  (p=0.008 n=5+5)
NewSafeIDParallel-20    24.2ns ± 6%    22.1ns ± 1%   -9.06%  (p=0.008 n=5+5)

name                  old alloc/op   new alloc/op   delta
NewSafeID-20             0.00B          0.00B          ~     (all equal)
NewSafeIDParallel-20     8.00B ± 0%     8.00B ± 0%     ~     (all equal)

name                  old allocs/op  new allocs/op  delta
NewSafeID-20              0.00           0.00          ~     (all equal)
NewSafeIDParallel-20      1.00 ± 0%      1.00 ± 0%     ~     (all equal)

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          messageID: add NewSafeID testcase

1265b2e

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          switch go code style for imports from gofmt to goimports

af5cf8b

Author

SteffenMahler commented Feb 14, 2022

I have switched to goimports for sorting and formatting of imports. So the linter check should be successful now.
Maybe we should integrate docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.44.0 golangci-lint run -v into the makefile?
Could you be so kind as to start the action again?

Thank you.

zchee added 8 commits

February 15, 2022 09:32


          all: support pass context.Context to all methods

0389f44

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          webhooks: remove go1.12 support

dacbdf8

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          misc: use NewRequestWithContext

d89251b

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          misc: use http.MethodXXX constant

1645ac2

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          messageID: fix atomic operation suggested by brainexe

daa4329

name                  old time/op    new time/op    delta
NewSafeID-20            7.60ns ± 1%    5.93ns ± 1%  -21.97%  (p=0.008 n=5+5)
NewSafeIDParallel-20    21.0ns ± 1%    21.0ns ± 2%     ~     (p=0.952 n=5+5)

name                  old alloc/op   new alloc/op   delta
NewSafeID-20             0.00B          0.00B          ~     (all equal)
NewSafeIDParallel-20     8.00B ± 0%     8.00B ± 0%     ~     (all equal)

name                  old allocs/op  new allocs/op  delta
NewSafeID-20              0.00           0.00          ~     (all equal)
NewSafeIDParallel-20      1.00 ± 0%      1.00 ± 0%     ~     (all equal)

See also:
- slack-go#1035 (review)

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          messageID: add documentation

93ff3fb

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          chat: add some BuildRequestContext methods for backwards compatibility

67b468f

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>


          webhook: remove unnecessary PostWebhookContextCustomHTTP function

741a1f5

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

zchee requested review from zchee and kanata2

February 24, 2022 14:25

zchee added 2 commits

February 25, 2022 01:30


          Merge pull request slack-go#1034 from zchee/ctx-aware

ff619ea

Support pass context.Context to all methods


          Merge pull request slack-go#1035 from zchee/opt-new-safe-id

f6658aa

Optimize NewSafeID using atomic

Contributor

zchee commented Feb 26, 2022

@SteffenMahler Hi, this is newer slack-go maintainer.

The webhooks_go112.go and webhooks_go113.go files has been removed (my previous pull request). Could you rebase it?

As you suggested:

Maybe we should integrate docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.44.0 golangci-lint run -v into the makefile?

Yeah, our GitHub Actions policy's don't running until accepted by any maintainers (I hope it's a commonly used policy). So contributor can't checks whether the will fail lint job or etc.
Make sense, I'll consider adding it. Thanks.

zchee added enhancement experimental needs review labels

Steffen Mahler added 8 commits

February 28, 2022 14:48


          introduce workflow step app functionality

486fde5


          tests for workflowStep added

b57471c


          example workflowStep app added

fabe21a


          readme improved

dd80d02


          unused variable in example removed, switch line indention to tabulator

81b0160


          using snake case for new directory and file

cd34138


          switch go code style for imports from gofmt to goimports

c90fe4e


          rebase

b5149b1

Author

SteffenMahler commented Feb 28, 2022

I don't know what I did wrong. Now there are changes in my branch that I didn't made and should already be in the main branch. Can you have a look?

Contributor

zchee commented Feb 28, 2022

@SteffenMahler Sure, will review soon.

victorboissiere commented Mar 2, 2022

FYI, we are currently using your branch in our internal project. This is working perfectly & deployed into production. Really much needed.

Contributor

zchee commented Mar 2, 2022

@victorboissiere Thanks for great feedback. We should merge ASAP anyway.

zchee approved these changes

View reviewed changes

Contributor

zchee left a comment

LGTM

zchee merged commit b5149b1 into slack-go:master

zchee mentioned this pull request

workflow_step: add SaveWorkflowStepConfigurationConetxt & fix return err #1042

Merged

kanata2 removed needs review feedback given labels

This was referenced Feb 9, 2025

Update module github.com/slack-go/slack to v0.16.0 stakater/slack-operator#74

Open

fix(deps): update module github.com/slack-go/slack to v0.16.0 shuymn/mature#346

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement experimental