Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step events now occur in parent Stepper #2341

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Dec 20, 2023

Linked Issue

Closes #2323

Description

Rather than pass the event dispatcher down through the context API, we now instead pass the individual event handler functions. This ensures the events trigger in the parent, which means the documentation matches implementation.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Sorry, something went wrong.

@endigo9740 endigo9740 linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 08db5cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 20, 2023 9:00pm

Copy link
Member

@TazorDE TazorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endigo9740 endigo9740 merged commit a9b3905 into dev Dec 20, 2023
@endigo9740 endigo9740 deleted the bug/stepper-event-handler-fix branch December 20, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid placement of Event
2 participants