Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Avatar fontSize prop #2322

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Feat: Avatar fontSize prop #2322

merged 2 commits into from
Dec 18, 2023

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Dec 18, 2023

Linked Issue

Closes #2321

Description

Added a fontSize prop that targets the font size for the initials, this allows for more fine grained control over the initials when having bigger or smaller avatars

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Sorry, something went wrong.

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2023 6:49pm

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 453e004

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Hugos68 Hugos68 changed the title Added avatar fontSize prop, updated tests. added changesets Feat: Avatar fontSize prop Dec 18, 2023
@Sarenor
Copy link
Contributor

Sarenor commented Dec 18, 2023

Looking good, thanks @Hugos68

Copy link
Contributor

@Sarenor Sarenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official Approval instead of comment, Still looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter font size for initials based Avatars
3 participants