Accept namespaces in sitePassByRefFunctions #351
Merged
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
force-pushed
the
accept-namespaces-in-pass-by-ref-functions
branch
from
83e12cb to
2e0ecf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the system that looks for pass-by-reference functions so that it will accept namespaced functions. This allows including things like
\My\Namespace\doSomething:1insitePassByRefFunctions.One thing to note: even with this change, if you list
function_name:1(without a namespace), it will still match\My\Namespace\function_name(). Changing this behavior would be a breaking change and I'm not sure it's even a good idea since the function may be aliased (eg;use \My\Namespace\function_name).Fixes #349