Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for #2540 #2551

Closed
wants to merge 17 commits into from
Closed

Conversation

mroderick
Copy link
Member

These are suggestions for #2540

I made a PR to make it easier to cherry pick the suggestions.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (docs-how-to@492a09e). Click here to learn what that means.

❗ Current head b6f692d differs from pull request most recent head 924555f. Consider uploading reports for the commit 924555f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             docs-how-to    #2551   +/-   ##
==============================================
  Coverage               ?   95.73%           
==============================================
  Files                  ?       40           
  Lines                  ?     1901           
  Branches               ?        0           
==============================================
  Hits                   ?     1820           
  Misses                 ?       81           
  Partials               ?        0           
Flag Coverage Δ
unit 95.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83
Copy link
Contributor

fatso83 commented Sep 29, 2023

Applied all! thank you 😗

@fatso83 fatso83 closed this Sep 29, 2023
@fatso83 fatso83 deleted the docs-how-to-mroderick-suggestions branch September 29, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants