Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an explicit error if the header value is not a string #53

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Throw an explicit error if the header value is not a string #53

merged 1 commit into from
Jun 1, 2018

Commits on Jun 1, 2018

  1. Throw an explicit error if the header value is not a string 

    According to RFC7230, http fields have used to be text and new
headers should continue to do so, restricting the values to consist
of US-ASCII octets.

This test is not so strict, but we avoid a whole range of errors
by just checking if the value is a string.

Ref sinonjs#51, sinonjs#48 and https://tools.ietf.org/html/rfc7230#section-3.2.4
    @fatso83
    fatso83 committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    a6790f0 View commit details
    Browse the repository at this point in the history