Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for keyboard jumping when switching focus from a TextField #1810

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

oligazar
Copy link
Contributor

@oligazar oligazar commented Apr 8, 2024

Description

When user switches focus from a TextField to QuillEditor keyboards "jumps". This happens, because _handleFocusChanged is called in a postFrameCallback if the state is dirty. So there's time to start hiding keyboard animation and the show it again.

This fixes it by requesting keyboard prior to calling _handleFocusChanged in a postFrameCallback.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

e.g.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Sorry, something went wrong.

oligazar added 2 commits April 2, 2024 11:55
@singerdmx singerdmx merged commit a2a4faf into singerdmx:master Apr 9, 2024
2 checks passed
theniceboy added a commit to theniceboy/flutter-quill that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard jumps when QuillEditor gains focus
2 participants