Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paste gif from clipboard #1788

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

sobimor
Copy link
Contributor

@sobimor sobimor commented Mar 26, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

e.g.

Improvements

Features

User can paste GIF from clipboard

Additional notes

Suggestions

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Sorry, something went wrong.

@sobimor
Copy link
Contributor Author

sobimor commented Mar 26, 2024

@singerdmx

@singerdmx singerdmx merged commit 05c17e1 into singerdmx:master Mar 28, 2024
2 checks passed
@EchoEllet
Copy link
Collaborator

Thank you for your contributions. We may want to be more specific about the reason why onGifPaste is separated from onImagePaste? super_clipboard does separate them all those formats for extensibility, with our new implementation (in #2230) we can simply have them in one method channel, also we can fallback between different formats and only use the onImagePaste and maybe providing a parameter about the image mime type or some additional details related to the clipboard item instead of introducing onGifPaste which need to be maintained separately, also it might not fix the extensibility issue.

Gif is an image of mime type image/gif, jpeg is image/jpeg, and png is image/png.

User can paste GIF from clipboard

Unfortunately, this is not a feature on all platforms (such as macOS) and needs more consideration before implementing it

image

@singerdmx We probably want to take code review more seriously.

@EchoEllet
Copy link
Collaborator

@sobimor Can you clarify on which platforms this feature has been tested?

@sobimor
Copy link
Contributor Author

sobimor commented Sep 24, 2024

@sobimor Can you clarify on which platforms this feature has been tested?

Android, and iOS

@EchoEllet
Copy link
Collaborator

EchoEllet commented Sep 24, 2024

Android, and iOS

Thank you for the clarification, this feature is not supported on web and desktop platforms (even on other native apps/plugins). We will have to remove it in the long term or change how it's handled, for now will document it only. More details in #2230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants