fix: multiline styling stuck/not working properly #1782
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug mentioned in #1550 , where doing styling in multiple lines at the same time doesn't change the toggle. This bug makes the editor so unintuitive.
Related Issues
Fix #1550
Improvements
This change enables us to do styling to multiple line at once without breaking the style toggle, (see #1550 for examples)
Additional notes
The issue was at lib\src\models\documents\nodes\line.dart at line 364-367, it compares
style.attributes[attr.key] != attr.value
when it should actually comparestyle.attributes[attr.key]?.value != attr.value
. At the issue you can see that @li3317 cannot reproduce it, it might be because in some version of dartanything == (bool)true
while in some version only(bool)true == (bool)true
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files../scripts/before_push.sh
and it all passed successfullyBreaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).