BREAKING CHANGE: Bump version of normalize-url to 8, dependency bumps #87
Conversation
| @@ -33,13 +33,17 @@ | |||
| "string" | |||
| ], | |||
| "dependencies": { | |||
| "normalize-url": "^7.0.2", | |||
| "re2": "^1.17.2", | |||
There was a problem hiding this comment.
re2 isn't used anywhere in the project
There was a problem hiding this comment.
It's required by url-regex-safe. Usually, git blame is a good way to find out why something exists.
There was a problem hiding this comment.
Makes sense, will add it back. Requiring a build step for this library feels a bit too much - I might open up an issue for discussion on using an alternate implementation
There was a problem hiding this comment.
Yeah, we can switch to https://github.com/sindresorhus/super-regex instead. Feel free to do that here.
.gitignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| node_modules | |||
| yarn.lock | |||
| .idea | |||
There was a problem hiding this comment.
Don't make unrelated changes.
There was a problem hiding this comment.
This is my IDEs config files, happy to remove
There was a problem hiding this comment.
Yes. It's your config. It has nothing to do in a repo. It should be in your own global gitignore.
|
@sindresorhus |
|
I will require Node.js 16 after merging this. |
|
Sounds good! I think PR is ready now |
Bumps dependency versions, fixes lint errors
There's a breaking change in normalize-url v7.0.3 around url query strings - sindresorhus/normalize-url#158 which I figured should be a major version bump