do not recommend consistent destructuring

See #1230 (comment) !1230
sindresorhus · Jan 17, 2024 · a1d78ed · a1d78ed
1 parent eb5af8b
commit a1d78ed
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/configs/recommended.js b/configs/recommended.js
@@ -2,7 +2,7 @@
 module.exports = {
 	'unicorn/better-regex': 'error',
 	'unicorn/catch-error-name': 'error',
-	'unicorn/consistent-destructuring': 'error',
+	'unicorn/consistent-destructuring': 'off',
 	'unicorn/consistent-function-scoping': 'error',
 	'unicorn/custom-error-definition': 'off',
 	'unicorn/empty-brace-spaces': 'error',

diff --git a/docs/rules/consistent-destructuring.md b/docs/rules/consistent-destructuring.md
@@ -1,6 +1,6 @@
 # Use destructured variables over properties
 
-💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs).
+🚫 This rule is _disabled_ in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs).
 
 🔧💡 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix) and manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "50.0.1",
+	"version": "51.0.0",
 	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",

diff --git a/readme.md b/readme.md
@@ -112,7 +112,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | :----------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :- | :- | :- |
 | [better-regex](docs/rules/better-regex.md)                                                       | Improve regexes by making them shorter, consistent, and safer.                                                                                                                                                    | ✅  | 🔧 |    |
 | [catch-error-name](docs/rules/catch-error-name.md)                                               | Enforce a specific parameter name in catch clauses.                                                                                                                                                               | ✅  | 🔧 |    |
-| [consistent-destructuring](docs/rules/consistent-destructuring.md)                               | Use destructured variables over properties.                                                                                                                                                                       | ✅  | 🔧 | 💡 |
+| [consistent-destructuring](docs/rules/consistent-destructuring.md)                               | Use destructured variables over properties.                                                                                                                                                                       |    | 🔧 | 💡 |
 | [consistent-function-scoping](docs/rules/consistent-function-scoping.md)                         | Move function definitions to the highest possible scope.                                                                                                                                                          | ✅  |    |    |
 | [custom-error-definition](docs/rules/custom-error-definition.md)                                 | Enforce correct `Error` subclassing.                                                                                                                                                                              |    | 🔧 |    |
 | [empty-brace-spaces](docs/rules/empty-brace-spaces.md)                                           | Enforce no spaces between braces.                                                                                                                                                                                 | ✅  | 🔧 |    |