Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gemfiles to manage dev/test dependencies + cleanup #1949

Merged
merged 8 commits into from
Sep 24, 2023
Merged

Use Gemfiles to manage dev/test dependencies + cleanup #1949

merged 8 commits into from
Sep 24, 2023

Commits on Sep 16, 2023

  1. Manage development dependencies with Gemfiles

    @dentarg
    dentarg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9b8b6e3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary sinatra-contrib dev deps

    @dentarg
    dentarg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0a8ea48 View commit details
    Browse the repository at this point in the history

  3. Remove Gemfile groups, it is all test/dev deps 

    Also

- No longer necessary to use slim main
- Sort list of deps alphabetically
    @dentarg
    dentarg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    4735681 View commit details
    Browse the repository at this point in the history

  4. Remove open-ended dependencies in gemspecs 

    To silence warnings from RubyGems.

These are the first published versions of these gems, so the change
should still allow any version to be used.

https://rubygems.org/gems/base64/versions
https://rubygems.org/gems/multi_json/versions
    @dentarg
    dentarg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    6871ce5 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Document yard dependency

    @dentarg
    dentarg committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e3b82c0 View commit details
    Browse the repository at this point in the history

  2. Remove activesupport from Gemfile 

    Looks like it has just stayed since sinatra#1425

We do get activesupport as an implicit dependency from rabl
    @dentarg
    dentarg committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    10b9b5c View commit details
    Browse the repository at this point in the history

  3. Remove json from Gemfile 

    I see no need to have it here. Looks like it has been with us from the
start: 5a3f133

Probably there was a need back in the days.
    @dentarg
    dentarg committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    6857f5d View commit details
    Browse the repository at this point in the history

  4. Remove jar-dependencies from Gemfile 

    There was a need [1] to avoid jar-dependencies 0.4.2 but that version has
since been yanked from RubyGems, so there is no need for this anymore.

1: 30f6325
    @dentarg
    dentarg committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    607cb3a View commit details
    Browse the repository at this point in the history