Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest liquid release in sinatra-contrib CI #1896

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Mar 5, 2023

2.6.x is very old, https://rubygems.org/gems/liquid/versions

2.6.3 - July 23, 2015 (45.5 KB)

Found these traces in history:

2.6.x is very old, https://rubygems.org/gems/liquid/versions

    2.6.3 - July 23, 2015 (45.5 KB)

Found these traces in history:

- sinatra@7416777
- sinatra/sinatra-contrib@2dc03c8
@dentarg dentarg marked this pull request as ready for review March 5, 2023 15:21
@dentarg
Copy link
Member Author

dentarg commented Mar 5, 2023

Seems to work well, still only JRuby that fails, due to #1886 (and #1857 solves it). I'll merge this.

@dentarg dentarg merged commit 0c926e6 into sinatra:master Mar 5, 2023
@dentarg dentarg deleted the test-with-modern-liquid branch March 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant