Rack 3 support #1857
Merged
Rack 3 support #1857
Commits on Jan 5, 2024
-
-
-
Probably too hard to make Sinatra work with both Rack 2 and Rack 3 in the same version.
-
-
-
SERVER_PROTOCOL->HTTP_VERSIONSimilar change as jeremyevans/roda@50f0ddf Good to know is that rack-test defaults to HTTP/1.0: https://github.com/rack/rack-test/blob/v2.0.2/lib/rack/test.rb#L277-L285 (so Rack::Lint does not catch all usage of HTTP_VERSION)
-
-
Find
RACK_SESSION_UNPACKED_COOKIE_DATAIt moved to Rack::Session: https://github.com/rack/rack-session/blob/v0.3.0/lib/rack/session/constants.rb
-
-
-
sinatra-contrib tests now pass
Multiple response header values are encoded using an Array instead of newlines: https://github.com/rack/rack/blob/v3.0.3/UPGRADE-GUIDE.md#multiple-response-header-values-are-encoded-using-an-array Rack 3 does not remove cookies from the internal storage (because it doesn't make much sense), see rack/rack#1844, rack/rack#1840
-
Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
-
Update routing test
handles params without a valueThe behaviour changed in Rack 3 with - rack/rack#1989 - rack/rack@ab1f1c1
-
Revert "Run tests for sinatra-contrib and rack-protection" This reverts commit 13b5b0f.
-
Depend on
rackupandrack-session>=2.0.0The 2.0 series of these games are the same as the 0.x series, as these gems were created for Rack 3. The 1.x series of these games are for Rack 2.
-
Rack::File->Rack::FilesagainRebase gone wrong. Remove the old comment from 1dfae3d.
-
Support
text/javascriptas JavaScript MIME typeNext Rack release (probably 3.1) will include this change: rack/rack@1bd0f15 sinatra#1857 (comment)
-
-
Revert "Update routing test
handles params without a value"Rack v3.0.7 rolled back this change with rack/rack#2059 Other references: - rails/rails#47652 - rack/rack#2052 - rack/rack#2038
-
-
-
-
Co-authored-by: Eloy Pérez <ej.perezgomez@gmail.com>
-
Require rack 3.0.0, not 3.0.0.beta1
No point in using the beta version anymore.
-
rack-protection depends on rack-session
The tests shows this after dcdebe9 Sinatra does not (yet?)
-
-
-
Skip "without rackup" test on rack head branch
Tried adding the same code the regular Gemfile has for rack head, but than I ran into /usr/local/bundle/gems/bundler-2.4.22/lib/bundler/source/git/git_proxy.rb:354:in `allowed_with_path': The git source https://github.com/rack/rack.git is not yet checked out. Please run `bundle install` before trying to start your application (Bundler::GitError) So it seems we need to bundle before trying to start the app, and that just feels too complicated. The thought of using bundler/inline has crossed my mind, maybe I will try it at some point. -
Fix
test_app_start_without_rackupon JVM rubiestruffleruby and jruby uses the childprocess with CHILDPROCESS_POSIX_SPAWN, and when doing so, the environment variables aren't cocered to strings until very late: https://github.com/enkessler/childprocess/blob/v4.1.0/lib/childprocess/unix/posix_spawn_process.rb#L109-L130 On CRuby it seems symbol environment variables will overwrite any existing (string) ones but that does not happen on JVM rubies (I've only tested with TruffleRuby though, but JRuby builds also failed in CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.