Use Gemfiles to manage dev/test dependencies + cleanup
#1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also - No longer necessary to use slim main - Sort list of deps alphabetically
To silence warnings from RubyGems. These are the first published versions of these gems, so the change should still allow any version to be used. https://rubygems.org/gems/base64/versions https://rubygems.org/gems/multi_json/versions
Looks like it has just stayed since sinatra#1425 We do get activesupport as an implicit dependency from rabl
I see no need to have it here. Looks like it has been with us from the start: 5a3f133 Probably there was a need back in the days.
There was a need [1] to avoid jar-dependencies 0.4.2 but that version has since been yanked from RubyGems, so there is no need for this anymore. 1: 30f6325
olleolleolle
approved these changes
Sep 22, 2023
Closed
dentarg
commented
Dec 29, 2023
| @@ -39,9 +39,6 @@ RubyGems 2.0 or newer is required to protect against public gem pushes. You can | |||
| s.required_ruby_version = '>= 2.6.0' | |||
|
|
|||
| # dependencies | |||
| s.add_dependency 'base64' | |||
| s.add_dependency 'base64', '>= 0.1.0' | |||
There was a problem hiding this comment.
It is still open-ended 😄 (same with multi_json in sinatra-contrib)
Not sure we need to act, hopefully conservative gems that don't change the API anytime soon (if ever?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits.
Close #1918