Merge pull request #1855 from dentarg/revert-rack3

Revert "Allow running with Rack 3. (#1811)"
sinatra · Dec 28, 2022 · 9b6ba81 · 9b6ba81
2 parents 3977c07 + f9fa73d
commit 9b6ba81
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,7 +11,7 @@ permissions:
 
 jobs:
   test:
-    name: ${{ matrix.ruby }} (Rack ${{ matrix.rack }}, Puma ${{ matrix.puma }}) ${{ matrix.gemfile }}
+    name: ${{ matrix.ruby }} (Rack ${{ matrix.rack }}, Puma ${{ matrix.puma }})
     permissions:
       contents: read #  to fetch code (actions/checkout)
       actions: read #  to list jobs for workflow run (8398a7/action-slack)
@@ -29,14 +29,11 @@ jobs:
         include:
           - { ruby: 2.6, rack: '~> 2', puma: '~> 5' }
           - { ruby: 3.2, rack: '~> 2', puma: '~> 5' }
-          - { ruby: 3.1, rack: stable, puma: stable, gemfile: gems/rack-v3.rb, allow-failure: true }
-          - { ruby: 3.1, rack: latest, puma: latest, gemfile: gems/rack-v3.rb, allow-failure: true }
-          - { ruby: jruby-head, rack: stable, puma: stable, gemfile: gems/rack-v3.rb, allow-failure: true }
+          - { ruby: 3.2, rack: '~> 2', puma: latest }
+          - { ruby: jruby-head, rack: '~> 2', puma: stable, allow-failure: true }
     env:
       rack: ${{ matrix.rack }}
       puma: ${{ matrix.puma }}
-      BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-
     steps:
     - name: Install dependencies
       run: |

diff --git a/Gemfile b/Gemfile
@@ -24,6 +24,7 @@ puma_version = { github: 'puma/puma' } if puma_version == 'latest'
 gem 'puma', puma_version
 
 gem 'minitest', '~> 5.0'
+gem 'rack-test', github: 'rack/rack-test'
 gem 'rubocop', '~> 1.32.0', require: false
 gem 'yard'
 

diff --git a/gems/rack-v3.rb b/gems/rack-v3.rb
diff --git a/rack-protection/Gemfile b/rack-protection/Gemfile
@@ -13,3 +13,5 @@ gem 'rack', rack_version
 gem 'sinatra', path: '..'
 
 gemspec
+
+gem 'rack-test', github: 'rack/rack-test'
diff --git a/sinatra-contrib/Gemfile b/sinatra-contrib/Gemfile
@@ -6,6 +6,8 @@ gemspec
 gem 'rack-protection', path: '../rack-protection'
 gem 'sinatra', path: '..'
 
+gem 'rack-test', github: 'rack/rack-test'
+
 group :development, :test do
   platform :jruby do
     gem 'json'

diff --git a/sinatra.gemspec b/sinatra.gemspec
@@ -46,7 +46,7 @@ RubyGems 2.0 or newer is required to protect against public gem pushes. You can
   s.required_ruby_version = '>= 2.6.0'
 
   s.add_dependency 'mustermann', '~> 3.0'
-  s.add_dependency 'rack', '>= 2.2.4', '< 4'
+  s.add_dependency 'rack', '~> 2.2', '>= 2.2.4'
   s.add_dependency 'rack-protection', version
   s.add_dependency 'tilt', '~> 2.0'
 

diff --git a/test/server_test.rb b/test/server_test.rb
@@ -24,7 +24,7 @@ def stop
     end
   end
 
-  register :mock, Mock
+  register 'mock', 'Rack::Handler::Mock'
 end
 
 class ServerTest < Minitest::Test